Instrument adapter queries for external programs. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benk-gc
force-pushed
the
benk--instrument-que-adapter-queries
branch
from
feed35c to
acb446f
Compare
benk-gc
force-pushed
the
benk--instrument-que-adapter-queries
branch
2 times, most recently
from
491f54a to
976ee88
Compare
When executing queries via the adapter, we may not recieve the instrumentation we expect. The ActiveRecord adapter uses a raw connection which bypasses the ActiveRecord instrumentation layer and instead talks directly to PG, making it impossible to know what queries are being executed. This change cribs heavily from the implementation of the `log` method on the `AbstractAdapter` class in ActiveRecord to make it easy to add instrumentation to an adapter. By default the instrumenter is set to `nil`, and instrumentation will be a no-op; otherwise the query will be instrumented via the `instrument` method and passed the relevant payload to handle. The structure of this is deliberately similar to that of the event emitted by ActiveRecord's `sql.active_record` notification.
benk-gc
force-pushed
the
benk--instrument-que-adapter-queries
branch
from
976ee88 to
af8d14c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing queries via the adapter, we may not recieve the instrumentation we expect. The ActiveRecord adapter uses a raw connection which bypasses the ActiveRecord instrumentation layer and instead talks directly to PG, making it impossible to know what queries are being executed.
This change cribs heavily from the implementation of the
logmethod on theAbstractAdapterclass in ActiveRecord to make it easy to add instrumentation to an adapter. By default the instrumenter is set tonil, and instrumentation will be a no-op; otherwise the query will be instrumented via theinstrumentmethod and passed the relevant payload to handle. The structure of this is deliberately similar to that of the event emitted by ActiveRecord'ssql.active_recordnotification.